Fixed #17404 - Prevent bulk checkout of assets across companies#17887
Merged
snipe merged 14 commits intogrokability:developfrom Sep 22, 2025
Merged
Conversation
marcusmoore
changed the title
…companies # Conflicts: # app/Http/Controllers/Assets/BulkAssetsController.php # tests/Feature/Checkouts/Ui/BulkAssetCheckoutTest.php
Collaborator
Author
|
Merge conflicts handled. |
marcusmoore
deleted the
fixes/17404-prevent-bulk-checkout-across-companies
branch
Member
|
I think another improvement might be pulling them out of the form itself, OR letting the show up in the bulk list but as disabled (and perhaps in red or with an error icon) so people can manually delete those before submitting. |
marcusmoore
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, with Full Multiple Companies Support enabled it is possible to check out an asset that belongs to a company to a user of another company when it is selected as part of a bulk checkout:
CleanShot.2025-09-18.at.16.58.40.mp4
With this PR that action is blocked and the user is presented with an error message "Error: One or more of the checkout target company and asset company do not match":
CleanShot.2025-09-18.at.17.01.10.mp4
Fixes #17404