Skip to content

with --no-interactive, make composer non-interactive aswell#17945

Merged
snipe merged 1 commit intogrokability:developfrom
kingspride:develop
Sep 29, 2025
Merged

with --no-interactive, make composer non-interactive aswell#17945
snipe merged 1 commit intogrokability:developfrom
kingspride:develop

Conversation

@kingspride
Copy link
Copy Markdown
Contributor

copy of PR #17938
copy due to wrong base.

Fix:
discovered that PHP Composer was not silenced when running upgrade.php with --no-interactive switch.
this broke our Ansible / GoCD Pipeline.

added an Environment Variable that sets composer into non-interactive mode aswell.

@snipe
Copy link
Copy Markdown
Member

snipe commented Sep 29, 2025

This looks much better, thanks! can you add that new env variable to the .env.example as well, so we can update the documentation?

@kingspride
Copy link
Copy Markdown
Contributor Author

kingspride commented Sep 29, 2025

I think that is not neccessary since it just uses an EV that controls composer, and only makes using the upgrade.php consistent.
its no EV thats meant for snipeIT itself...

see https://getcomposer.org/doc/03-cli.md#composer-no-interaction

@snipe snipe merged commit ff1297c into grokability:develop Sep 29, 2025
2 checks passed
@snipe
Copy link
Copy Markdown
Member

snipe commented Sep 29, 2025

Looks like this may have created a bug? #17946

@snipe
Copy link
Copy Markdown
Member

snipe commented Sep 29, 2025

Never mind - it seemed unrelated, but I don't think it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants