Fixed #18316 - Adds #18316 category to pending acceptance index table#18332
Merged
snipe merged 3 commits intogrokability:developfrom Dec 11, 2025
Merged
Conversation
1 task
|
@Godmartinz |
snipe
changed the title
snipe
requested changes
Dec 11, 2025
Member
snipe
left a comment
snipe
left a comment
There was a problem hiding this comment.
This wouldn't account for items that don't have a model (all non-assets) that still have a category though.
Member
|
I think we'd probably want to use the more modern accessor style here? I suppose this is fine, but we use the more modern version in most other places. |
Member
Author
|
refactored. Looks better too 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds the category column to the list of items pending acceptance by a user. Also adds an accessor method to chain correctly for the category names.
EDIT: updated accessor to laravel 11.x standards
Fixes #18316