Fixed #18135 - only unset sensitive variables in the web UI importer#18439
Merged
Fixed #18135 - only unset sensitive variables in the web UI importer#18439
Conversation
snipe
changed the title
snipe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #18135, where cli user imports were failing because of the added security check to make sure the acting user can perform actions on other users that could compromise security (changing a superusers password or email, etc.)
This gets a little tricky because while the Web UI knows who the authenticated user is, the command line importer has no real way of knowing that (since a cli session is by nature unauthenticated - there is no session.)
This change checks to see if the user is authenticated (meaning it's being run via CLI) and then also uses the gate to check that the authenticated user can change those sensitive fields.