Skip to content

Conversation

@jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented Jul 15, 2024

Description

This pull request changes the following:

  • helm dependency update chart.lock
  • updated haproxy.cfg to set password via environment variable from secret for dataplane user and stats user & password
  • updated haproxy liveness/readiness/startup probe to work with password coming from environment variable

Related Issues

@github-actions
Copy link

Unit Test Results

  26 files  ±0    26 suites  ±0   56s ⏱️ -39s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ±0 

Results for commit cc87ce1. ± Comparison against base commit dbed2f9.

@codecov
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.17%. Comparing base (dbed2f9) to head (cc87ce1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #921   +/-   ##
=========================================
  Coverage     67.17%   67.17%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1319     1319           
  Branches        157      157           
=========================================
  Hits            886      886           
  Misses          370      370           
  Partials         63       63           

Impacted file tree graph

@sonarqubecloud
Copy link

@jeromy-cannon jeromy-cannon merged commit e162d3d into main Jul 16, 2024
@jeromy-cannon jeromy-cannon deleted the 00920-haproxy-bug-fix branch July 16, 2024 10:19
swirlds-automation added a commit that referenced this pull request Aug 1, 2024
## [0.29.0](v0.28.3...v0.29.0) (2024-08-01)

### Features

* add extra container for sidecar uploader ([#926](#926)) ([58ff515](58ff515))

### Bug Fixes

* haproxy fails to start ([#921](#921)) ([e162d3d](e162d3d))
* incorrect NODE_NAMES ([#925](#925)) ([81629a8](81629a8))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Charts[Network]: BUG: haproxy fails to start Charts[Network]: haproxy.cfg stats auth is using random which changes upon helm upgrade

5 participants