feat: add extra container for sidecar uploader #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
…upload-sidear Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
JeffreyDallas
requested review from
dalvizu,
jeromy-cannon,
leninmehedy and
matteriben
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
=========================================
Coverage 67.17% 67.17%
Complexity 339 339
=========================================
Files 64 64
Lines 1319 1319
Branches 157 157
=========================================
Hits 886 886
Misses 370 370
Partials 63 63 |
leninmehedy
reviewed
Jul 17, 2024
leninmehedy
reviewed
Jul 17, 2024
Ivo-Yankov
requested changes
Jul 18, 2024
Contributor
Ivo-Yankov
left a comment
Ivo-Yankov
left a comment
There was a problem hiding this comment.
Looks good. Can you also add one more change to fullstack-deployment/values.yaml: Set this value hedera.mirror.importer.parser.record.sidecar.enabled=true. This will enable the importing of sidecar records to the mirror node.
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
|
Contributor
|
🎉 This PR is included in version 0.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Related Issues