Wunderground not working since 0.65

[arsaboo]

Home Assistant release (hass --version): 0.65

Python release (python3 --version): 3.6.2

Component/platform: Wunderground

Description of problem: Seeing the following errors since the update.

2018-03-09 14:24:47 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up platform wunderground
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 82, in async_setup
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception
  File "/usr/lib/python3.6/asyncio/tasks.py", line 180, in _step
    result = coro.send(None)
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/sensor/wunderground.py", line 647, in async_setup_platform
    yield from rest.async_update()
  File "/usr/lib/python3.6/asyncio/coroutines.py", line 213, in coro
    res = yield from res
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/sensor/wunderground.py", line 787, in async_update
    result = yield from response.json()
TypeError: cannot 'yield from' a coroutine object in a non-coroutine generator

cc: @OttoWinter looks like it is related to #12385

[OttoWinter]

Hmmm, there was no change to the WUndergroud platform in 0.65.0 ... only thing I can think of that could potentially somehow cause this is the aiohttp update, but the error log hints at something else.

If I understand correctly, the error I'm seeing in your logs is that the somewhere in the call chain we're expecting a coroutine, but are not inside a coroutine: "The async_update method is called outside of a coroutine." Maybe it's the @Throttle decorator being before the @asyncio.coroutine decorator, but several other integrations are doing it like this too (startca, bluesound, sbnzbd, hydroquebec, etc.). Additionally, there hasn't been a change to the Throttle decorator in quite some time too.

The other thing I find interesting is that, if I understand correctly, coroutines are essentially just generators. So therefore we should still be able to use yield from even though the call chain doesn't have a coroutine...

I will try to take a closer look at this later, but it seems to be due to some core change IMO.

[arsaboo]

Let me know if you want me to test out something.

[MartinHjelmare]

My money is on the order of decorators. 👍

[arsaboo]

If it is simply switching the order of these two....I can try it in a custom_component?

    @asyncio.coroutine
    @Throttle(MIN_TIME_BETWEEN_UPDATES)

[OttoWinter]

Nopes, was just verify the issue and it doesn't seem to be the order of decorators.

[danodemano]

I'm seeing the same thing and happy to test any fixes as well. I'm on Python 3.5.3.

2018-03-09 15:36:18 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up platform wunderground
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/homeassistant/helpers/entity_platform.py", line 82, in async_setup
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/lib/python3.5/asyncio/tasks.py", line 400, in wait_for
    return fut.result()
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
    result = coro.send(None)
  File "/usr/local/lib/python3.5/dist-packages/homeassistant/components/sensor/wunderground.py", line 647, in async_setup_platform
    yield from rest.async_update()
  File "/usr/lib/python3.5/asyncio/coroutines.py", line 213, in coro
    res = yield from res
  File "/usr/local/lib/python3.5/dist-packages/homeassistant/components/sensor/wunderground.py", line 787, in async_update
    result = yield from response.json()
TypeError: cannot 'yield from' a coroutine object in a non-coroutine generator

[balloob]

I would expect that changing the 2 decorators is going to fix it too.

[arsaboo]

If I switch the two decorators to

    @Throttle(MIN_TIME_BETWEEN_UPDATES)
    @asyncio.coroutine

I get the following error:

Log Details (ERROR)
Fri Mar 09 2018 16:02:08 GMT-0500 (Eastern Standard Time)

wunderground: Error on device update!
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 188, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 325, in async_device_update
    yield from self.async_update()
  File "/home/homeassistant/.homeassistant/custom_components/sensor/wunderground.py", line 736, in async_update
    yield from self.rest.async_update()
TypeError: 'NoneType' object is not iterable

[balloob]

Which is correct. Because Throttle was never meant to support asyncio. That however is easier fixable.

[balloob]

Try removing the asyncio coroutine, add async before def async_update() and replace yield from with await

[arsaboo]

Like this: ?

    @Throttle(MIN_TIME_BETWEEN_UPDATES)
    async def async_update(self):
        """Get the latest data from WUnderground."""
        try:
            with async_timeout.timeout(10, loop=self._hass.loop):
                response = await self._session.get(self._build_url())
            result = await response.json()
            if "error" in result['response']:
                raise ValueError(result['response']["error"]["description"])
            self.data = result
        except ValueError as err:
            _LOGGER.error("Check WUnderground API %s", err.args)
        except (asyncio.TimeoutError, aiohttp.ClientError) as err:
            _LOGGER.error("Error fetching WUnderground data: %s", repr(err))

[arsaboo]

Still the same error.

Log Details (ERROR)
Fri Mar 09 2018 16:08:58 GMT-0500 (Eastern Standard Time)

wunderground: Error on device update!
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 188, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 325, in async_device_update
    yield from self.async_update()
  File "/home/homeassistant/.homeassistant/custom_components/sensor/wunderground.py", line 736, in async_update
    yield from self.rest.async_update()
TypeError: 'NoneType' object is not iterable

[OttoWinter]

I think we need the only way to fix this is it create an AsyncThrottle decorator. (Or we make Throttle return a coroutine by default/via an option)

I won't be home for the rest of the night, so I can't work on a quick fix right now. But I think such a fix would be quite good since quite a few integrations are using Throttle with as a coroutine wrapper.

[balloob]

Yeah, I'll make Throttle async aware