Conversation
balloob
commented
Mar 9, 2018
| """Get the latest data from luftdaten.info and update the state.""" | ||
| try: | ||
| yield from self.luftdaten.async_update() | ||
| except TypeError: |
Member
Author
There was a problem hiding this comment.
Removed this type error because that would happen if Throttle was returning None…
balloob
added a commit
that referenced
this pull request
Mar 10, 2018
* Make Throttle async aware * Lint
Merged
|
Heres the sabnzdb log (I'm home now and I can paste it - not on iPad now) |
Member
Author
|
sabnzdb has been fixed in #13042 |
|
I think the Tado component suffers from the same issue (Also like #13012) |
Member
Author
|
@thomasvt1 thanks for the report, opened #13078 with a fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Throttle was not async aware. With coroutines these errors got swallowed but with async/await they surfaced, which is good as now we have been able to squash a bunch of bugs.
Found all instances where we combined an
@async.coroutinewith a@Throttle. I've converted them all to async/await and also fixed the Throttle decorator.Found all instances with:
Related issue (if applicable): fixes #13012
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: