MQTT RGB support scene broken

[moskovskiy82]

Before switching to 0.66 (from 0.65) everything was working fine. But now my RGB light doesn’t work inside a scene. Only from the scene as it works as expected when playing with it from the frontend… Wonder what can be the cause. Did i miss something?!
RGB light is an esp8266 code from github (i believe this one https://github.com/corbanmailloux/esp-mqtt-rgb-led)

The only thing i could find that changed is the #11288

But i lack the knowledge to understand that this is the case but maybe some experts can help like @balloob and @armills

Light config

- platform: mqtt_json
  name: Zal RGB
  state_topic: "light/zalrgb"
  command_topic: "light/zalrgb/set"
  brightness: true
  rgb: true
  white_value: true
  effect: true
  effect_list: [colorfade_slow, colorfade_fast, flash]
  optimistic: false
  qos: 0

Scene example

  - name: zal_light_bright
    entities:
        light.zwave_zal_small_level:
          state: on
          brightness: 255
        light.zwave_zal_big_level:
          state: on
          brightness: 255
        light.zal_rgb:
          state: on
          rgb_color: [255, 64, 0]
          white_value: 255
          brightness: 255
        light.zal_xiaomi:
          state: on
          rgb_color: [255,118,73]
          brightness: 255
        light.mys_koridor_37_1:
          state: on
          rgb_color: [255,128,0]
          brightness: 255

[gmschade]

I am seeing the same problem, after doing a bit of sniffing on the mqtt set topic it looks like 'xy' is turned on, even tho it is set to false.
Light:

- platform: mqtt_json
  name: 'Living Room Floor 1'
  state_topic: 'livingroom/floorlight1'
  command_topic: 'livingroom/floorlight1/set'
  color_temp: true
  brightness: true
  rgb: true
  white_value: true
  effect: true
  optimistic: false
  xy: false

Automation:

- alias: 'test'
  initial_state: 'on'
  trigger:
    - platform: sun
      event: sunset
      offset: "-0:30:00"
  action:
    - service: light.turn_on
      data:
        entity_id: light.living_room_floor_1
        white_value: 110
        rgb_color: [255, 252, 247]
        brightness: 255
        transition: 30

mqtt:

mosquitto_sub -h ***** -u ****** -P ***** -t livingroom/floorlight1/set
{"state": "ON", "color": {"r": 255, "g": 252, "b": 247, "x": 0.326, "y": 0.341}, "transition": 30, "brightness": 255, "white_value": 110}

If i do a publish excluding the "x" and "y" values it works:

mosquitto_pub -h ***** -u ***** -P ***** -t livingroom/floorlight1/set -m '{"state": "ON", "color": {"r": 255, "g": 252, "b": 247}, "transition": 30, "brightness": 255, "white_value": 110}'

EDIT:
I tried setting 'xy' to true to see if logic got reversed, did not change behavior

[emlove]

Thanks for providing this info!

I've put up a PR for a potential fix, but I don't use this platform myself. Could one of you test this to confirm that it fixes the problem?

#13617

[gmschade]

Yeah, I will try implementing the fix, may take me a bit to get there...

[gmschade]

yes it works for me. I tried it with a couple of different automations.
Thank You for the quick fix.

I also did a couple of tests to see if the mqtt_json looked right:

rgb: true :

{"state": "ON", "color": {"r": 255, "g": 252, "b": 247}, "transition": 30, "brightness": 255, "white_value": 110}

xy: true :

{"state": "ON", "color": {"x": 0.326, "y": 0.341}, "transition": 30, "brightness": 255, "white_value": 110}

[moskovskiy82]

Works for me as well! Thanks!

[JohanLeirnes]

The PR that @armills submitted did some wierd stuff when trying to change to white color while at a lower brightness level.

The component sends RGB color in the same value as brightness on a lower value.
This kills my mqtt_json lights as they are programmed to change to white mode when RGB is set to 255,255,255.

if they are dimmed on half brightness in blue color klicking in the middle of the colorwheel should send rgb 255,255,255 and brightness 128 or somthing like that. Right now it sends rgb 128,128,128