Conversation
| if self._rgb: | ||
| brightness = kwargs.get( | ||
| ATTR_BRIGHTNESS, | ||
| self._brightness if self._brightness else 255) |
There was a problem hiding this comment.
What if self._brightness is 0? Then the hsv to rgb converter would check with full brightness. Probably not really a problem since when brightness is zero, rgb is essentially ignored by the remote device. But still this behavior of having very different values with 0 and 1 brightness seems weird to me. Might very well be wrong though
There was a problem hiding this comment.
Don't disagree, but I'd leave that up to someone who uses this platform. Probably checking for None was the original intention.
There was a problem hiding this comment.
Don't disagree, but I'd leave that up to someone who uses this platform. Probably checking for None was the original intention.
There was a problem hiding this comment.
I can confirm that PR fixes the problem with scenes
…into dev * 'dev' of https://github.com/home-assistant/home-assistant: (43 commits) Upgrade py-cpuinfo to 4.0.0 (home-assistant#13629) changed PyTado version (home-assistant#13626) Hue mireds value is actually 153 not 154 (home-assistant#13601) Version bump to 0.66.1 Fix mysensors sensor type lookup (home-assistant#13574) Add pincode fallback (home-assistant#13587) Fix mqtt_json color commands (home-assistant#13617) Fix mqtt_json color commands (home-assistant#13617) Bugfix for tradfri to correctly execute Command. (home-assistant#13618) Fix Hue error logging (home-assistant#13616) Add pincode fallback (home-assistant#13587) Use 0/1 for raspberry pi cover GPIO writes rather than true/false (home-assistant#13610) Make mysensors updates and platform setup async (home-assistant#13603) Unflake folder watcher test (home-assistant#13569) Re-add group polling as a fallback for observation (home-assistant#13613) Fix IMAP email message_data (home-assistant#13606) Broadlink (home-assistant#13585) Version bump frontend done right Fix mysensors update callback (home-assistant#13602) Version bump to 0.66.1b0 ...
ghost
added
6 participants
Description:
It looks like after #11288 , the mqtt json color commands were combined, which breaks some lights. This PR fixes the mqtt_json light platform to respect the configuration.
Related issue (if applicable): fixes #13611