BMW device tracker - fix toggling state if vehicle tracking is disabled

[ChristianKuehnel]

Description:

If remote tracking is disabled in the vehicle, the position was toggling in the device tracker. Now, the position in the device trackier is only updated if remote tracking is enabled.

Related issue (if applicable): fixes ##12698

Pull request in home-assistant.github.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

no changes

Checklist:

• The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass

[gerard33]

@ChristianKuehnel Was wondering why this PR is closed as this will be a solution to prevent toggling of the device tracker when remote tracking is disabled?

[ChristianKuehnel]

Honestly I have no idea. I guess I closed the wrong ticket...

[ChristianKuehnel]

Do we really need all of the different name attributes of the tracker? I just used the pattern I saw in tesla, but I'm not sure if that really makes sense:
https://github.com/ChristianKuehnel/home-assistant/blob/351bc62f4aa9fe3d5328f7f72883e733c3c63db8/homeassistant/components/device_tracker/bmw_connected_drive.py#L52-L54

[MartinHjelmare]

Attributes are optional. dev_id is required and host_name nice to set to get a friendly name in the frontend. Each integration can add additional info in attributes that relate to the state of the device.

[MartinHjelmare]

Let me know when to merge.

[ChristianKuehnel]

@MartinHjelmare Thx for the review and the hint. I removed the attributes as they are redundant...

Ready to be merged.

[MartinHjelmare]

Thanks!