Skip to content

BMW device tracker - fix toggling state if vehicle tracking is disabled #12999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 2 commits into from
Mar 30, 2018
Merged

BMW device tracker - fix toggling state if vehicle tracking is disabled #12999

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
351bc62
if tracking is disabled, the position is not set in the device tracker.
ChristianKuehnel Mar 8, 2018
2e85e2f
removed useless attributes
ChristianKuehnel Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions homeassistant/components/device_tracker/bmw_connected_drive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,20 @@ def __init__(self, see, vehicle):
self.vehicle = vehicle

def update(self) -> None:
"""Update the device info."""
"""Update the device info.

Only update the state in home assistant if tracking in
the car is enabled.
"""
dev_id = slugify(self.vehicle.name)

if not self.vehicle.state.is_vehicle_tracking_enabled:
_LOGGER.debug('Tracking is disabled for vehicle %s', dev_id)
return

_LOGGER.debug('Updating %s', dev_id)
attrs = {
'trackr_id': dev_id,
'id': dev_id,
'name': self.vehicle.name
}

self._see(
dev_id=dev_id, host_name=self.vehicle.name,
gps=self.vehicle.state.gps_position, attributes=attrs,
icon='mdi:car'
gps=self.vehicle.state.gps_position, icon='mdi:car'
)