updated to new "b2vapi" of BMW ConnectedDrive#13305
updated to new "b2vapi" of BMW ConnectedDrive#13305MartinHjelmare merged 7 commits intohome-assistant:devfrom
Conversation
MartinHjelmare
left a comment
There was a problem hiding this comment.
Components should not create home assistant groups. That is for users only to do.
There was a problem hiding this comment.
I don't think we should create groups automatically. Let the users do that if they want.
There was a problem hiding this comment.
OK, removed the groups again.
I though it would be handy, as a vehicle might end up with 10-15 individual sensors. And creating the groups manually is annoying...
4e98184 to
3872022
Compare
16abde6 to
08150ec
Compare
|
Implementation and tests completed, ready to be reviewed and merged. |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks great! Two small comments.
| """ | ||
| import logging | ||
| import datetime | ||
|
|
There was a problem hiding this comment.
Please keep the blank line between standard library and 3rd party imports.
| @@ -6,7 +6,6 @@ | |||
| """ | |||
| import logging | |||
| import datetime | |||
There was a problem hiding this comment.
Please sort 🔤 within groups standard library, 3rd party and homeassistant imports.
57ed1bb to
0719380
Compare
| import datetime | ||
|
|
||
| import logging | ||
| import voluptuous as vol |
There was a problem hiding this comment.
There should be a blank line here between logging and voluptuous.
Description:
To support users from USA and Canada, the bimmer_connected library moved to a different API on the BMW servers. As this is a breaking changes for the bimmer_connected library, several changes were required to the Home Assistant modules.
The
countryattribute in the configuration is now replaced with aregionattribute.Related issue (if applicable): fixes N/A
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4947
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: