Skip to content

Removed the google home warning from emulated_hue#13436

Merged
balloob merged 3 commits intohome-assistant:devfrom
point-4ward:patch-1
Mar 25, 2018
Merged

Removed the google home warning from emulated_hue#13436
balloob merged 3 commits intohome-assistant:devfrom
point-4ward:patch-1

Conversation

@point-4ward
Copy link
Copy Markdown
Contributor

Description:

I've removed the warning that says: "When targeting google home you must use port 80" or something similar because, frankly, it's the most annoying thing that every time I reboot I have to see it, and it's completely pointless for the following reasons:

1 - It is abundantly clear in the docs that this is the case
2 - According to the docs, 'new' google_home users can't use emulated_hue anyway.
3 - 'Old' google_home users have surely got their settings right by now
4 - According to the docs the 'alexa' type is deprecated, which means that EVERYONE who is running an alexa device is getting this warning on every restart,
5 - I know I could just ignore the warning, but it's annoying and as per the reaons above, completely pointless.

Ta

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @mf-social,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@point-4ward
Copy link
Copy Markdown
Contributor Author

The travis check is failing because tox is testing whether the warning is issued, I have no idea about how the test bit works, but obviously that warning isn't issued because I've removed it, which is kinda the point of the PR.

If somebody can tell me how to remove that test I'll sort it, thanks!

@point-4ward
Copy link
Copy Markdown
Contributor Author

nvm - think I've sussed it.

@point-4ward
Copy link
Copy Markdown
Contributor Author

OK - sorted - but cla-bot got stuck :/

@point-4ward
Copy link
Copy Markdown
Contributor Author

point-4ward commented Mar 24, 2018

@fabaff - can you give cla-bot a kick? It's labelled me as signed, but is still showing as pending 3 hours later - ta!

In fact, looking down the list there's one that's been pending for 15 hours!

@balloob balloob merged commit 2d2e803 into home-assistant:dev Mar 25, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 25, 2018

I actually think that Google Home doesn't even work with Emulated Hue anymore as they have disabled local Hue discovery

@point-4ward point-4ward deleted the patch-1 branch April 9, 2018 23:00
@balloob balloob mentioned this pull request Apr 13, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants