Skip to content

Removed the google home warning from emulated_hue #13436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 3 commits into from
Mar 25, 2018
Merged

Removed the google home warning from emulated_hue #13436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80ec249
Removed the google home warning from emulated_hue
Mar 24, 2018
9b6760a
Update test_init.py
Mar 24, 2018
c03968f
Update test_init.py
Mar 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions homeassistant/components/emulated_hue/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,6 @@ def __init__(self, hass, conf):
"Listen port not specified, defaulting to %s",
self.listen_port)

if self.type == TYPE_GOOGLE and self.listen_port != 80:
_LOGGER.warning("When targeting Google Home, listening port has "
"to be port 80")

# Get whether or not UPNP binds to multicast address (239.255.255.250)
# or to the unicast address (host_ip_addr)
self.upnp_bind_multicast = conf.get(
Expand Down
16 changes: 1 addition & 15 deletions tests/components/emulated_hue/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from unittest.mock import patch, Mock, mock_open

from homeassistant.components.emulated_hue import Config, _LOGGER
from homeassistant.components.emulated_hue import Config


def test_config_google_home_entity_id_to_number():
Expand Down Expand Up @@ -112,17 +112,3 @@ def test_config_alexa_entity_id_to_number():

entity_id = conf.number_to_entity_id('light.test')
assert entity_id == 'light.test'


def test_warning_config_google_home_listen_port():
"""Test we warn when non-default port is used for Google Home."""
with patch.object(_LOGGER, 'warning') as mock_warn:
Config(None, {
'type': 'google_home',
'host_ip': '123.123.123.123',
'listen_port': 8300
})

assert mock_warn.called
assert mock_warn.mock_calls[0][1][0] == \
"When targeting Google Home, listening port has to be port 80"