Channel up and down for webostv#13624
Conversation
|
Hi @stephanerosi, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
7d6ea2a to
84df62e
Compare
syssi
left a comment
There was a problem hiding this comment.
It's a breaking change somehow but I support the suggestion!
|
When this PR will be implement to master Home Assistant ? |
|
Could you please make sure this works only when "Live TV" is the active source. Mostly these buttons are for next/previous track/menu, and since most people use services like plex netflix youtube etc rather than live tv, the intuitive default behavior would rather be previous and next (episode, video on playlist, etc) and not tv channel manipulation. |
|
@ferdydek |
|
@pvizeli |
This enable using the next and previous buttons on the media player interface to switch channels up and down, which is the desired default behaviour for a television.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: