Skip to content

Webostv channel up down only on LiveTV#13829

Merged
pvizeli merged 1 commit intohome-assistant:devfrom
stephanerosi:webostv-channel-up-down
Apr 12, 2018
Merged

Webostv channel up down only on LiveTV#13829
pvizeli merged 1 commit intohome-assistant:devfrom
stephanerosi:webostv-channel-up-down

Conversation

@stephanerosi
Copy link
Copy Markdown
Contributor

Description:

As per comment in related PR, restricts channels up down only when on television

Related issue (if applicable): fixes #13624

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ferdydek
Copy link
Copy Markdown

if the new one is accepted its no longer breaking change.
@stephanerosi could you add the info on docs.

@pvizeli pvizeli added this to the 0.67 milestone Apr 12, 2018
@pvizeli pvizeli merged commit d2804b0 into home-assistant:dev Apr 12, 2018
@ferdydek
Copy link
Copy Markdown

ferdydek commented Apr 12, 2018

tested, works as expected.
what would be a good next step is to disable in UI those media_player buttons that are inactive for most common sources like chromecast, roku, fire and most popular webos apps.

@ghost
Copy link
Copy Markdown

ghost commented Apr 13, 2018

Hi
I also tested and works perfect.

@balloob balloob mentioned this pull request Apr 13, 2018
stephanerosi added a commit to stephanerosi/home-assistant.github.io that referenced this pull request Apr 15, 2018
@stephanerosi
Copy link
Copy Markdown
Contributor Author

@ferdydek Hello, I updated the docs as requested :-)
home-assistant/home-assistant.io#5183

fabaff pushed a commit to home-assistant/home-assistant.io that referenced this pull request Apr 15, 2018
* Media player webostv next/previous buttons

Description of the change visibles in home-assistant/core#13829

* Fix formatting
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants