Add general sound mode support#14729
Merged
balloob merged 6 commits intohome-assistant:devfrom Jun 7, 2018
Merged
Conversation
houndci-bot
reviewed
May 31, 2018
|
|
||
| hass.services.call(DOMAIN, SERVICE_SELECT_SOUND_MODE, data) | ||
|
|
||
|
|
| data[ATTR_ENTITY_ID] = entity_id | ||
|
|
||
| hass.services.call(DOMAIN, SERVICE_SELECT_SOUND_MODE, data) | ||
|
|
Contributor
Author
|
@rytilahti I made this PR so you can base your Songpal component on it. |
Member
|
Can you add it to the demo media player and make sure it's tested ? |
Contributor
Author
|
@balloob I will do that on monday. And also test it on monday. |
fabaff
changed the title
houndci-bot
reviewed
Jun 4, 2018
|
|
||
|
|
||
| YOUTUBE_COVER_URL_FORMAT = 'https://img.youtube.com/vi/{}/hqdefault.jpg' | ||
| SOUND_MODE_LIST = ['Dummy Music','Dummy Movie'] |
Contributor
Author
|
@balloob I have updated my HomeAssistant to version 0.70.1 and tested this code. Can you now merge this PR? |
2 tasks
Contributor
Author
|
@balloob could you do a final review of this PR for sound mode support? |
balloob
approved these changes
Jun 7, 2018
Member
|
🎉 |
This was referenced Jun 10, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Media player: general sound mode support * General sound mode support * White spaces * Add sound mode support to demo media player * white space * remove unnessesary code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
General sound mode support for the Media player component.
See the discussion in the architecture fork: home-assistant/architecture#23
**Developers Docs: home-assistant/developers.home-assistant#17
**Needed as a basis for: #14718
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5495
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: