Skip to content

Media player: sound mode structure#17

Merged
balloob merged 2 commits intohome-assistant:masterfrom
starkillerOG:patch-1
Jun 1, 2018
Merged

Media player: sound mode structure#17
balloob merged 2 commits intohome-assistant:masterfrom
starkillerOG:patch-1

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

see this Issue in the architecture fork: home-assistant/architecture#23

see this Issue in the architecture fork: home-assistant/architecture#23
| ---- | ---- | ------- | -----------
| sound_mode | string | None | The current sound mode of the media player
| sound_mode_list | list | None | Dynamic list of available sound modes (set by platform)
| support_select_sound_mode | boolean | False | Boolean if select sound mode command supported
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a flag in supported_features or just decided upon whether the sound_mode_list is empty or not? The example below should also show the way how to do it (and also include the sound_mode & sound_mode_list methods, right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this should not be it's own boolean.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it.
I agree it makes more sense to just look if sound_mode_list is empty or not.

@starkillerOG
Copy link
Copy Markdown
Contributor Author

@balloob do you have any additional comments or do you agree with this structure?
What is the next step?
Shall I make a PR for just general sound mode support, or combine it with the denonavr and general sound mode support?
Or is there something else that needs to be done before starting on the PR for media_player/init.py?

@balloob balloob merged commit 9f3ca0b into home-assistant:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants