fix: remove keyword-only constraint on ScyllaDB process_batch param#40
Draft
hussein-awala wants to merge 1 commit intomainfrom
Draft
fix: remove keyword-only constraint on ScyllaDB process_batch param#40hussein-awala wants to merge 1 commit intomainfrom
hussein-awala wants to merge 1 commit intomainfrom
Conversation
The base class _batch_run calls process_batch via run_in_executor for sync implementations, which passes args positionally. The keyword-only `*, batch` signature causes a TypeError in this path since run_in_executor cannot pass keyword arguments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hussein-awala
force-pushed
the
fix/scylladb-process-batch-signature
branch
from
8ede7ea to
8a72ee3
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncScyllaDbWriteBatcher.process_batchuses*, batch(keyword-only), but the base class_batch_runcalls it viarun_in_executorfor sync implementations, which passes args positionallyrun_in_executorcannot pass keyword arguments, so this would raise aTypeErrorat runtime*to makebatcha regular positional parameter, consistent with all otherprocess_batchimplementationsTest plan
run_in_executorpath works with the fix🤖 Generated with Claude Code