fix: validate ScyllaDB operations before BatchQuery execution#52
Draft
hussein-awala wants to merge 1 commit intomainfrom
Draft
fix: validate ScyllaDB operations before BatchQuery execution#52hussein-awala wants to merge 1 commit intomainfrom
hussein-awala wants to merge 1 commit intomainfrom
Conversation
Previously, validation happened inside the BatchQuery context manager, so valid operations in the same batch would be committed even when other operations had validation errors. This caused partial batch execution that callers couldn't easily detect. Now all operations are validated upfront. Only valid operations are added to the BatchQuery, ensuring the batch is either fully valid or all invalid operations are reported without partial side effects. Also removes keyword-only constraint on batch param to match the base class contract (fixes run_in_executor compatibility). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BatchQuerycontext manager, so valid operations were committed even when other operations in the same batch had validation errorsBatchQuery*, batchconstraint to match the base class contract (fixesrun_in_executorcompatibility — see fix: remove keyword-only constraint on ScyllaDB process_batch param #40)Test plan
🤖 Generated with Claude Code