fix: use put_nowait to avoid race condition on queue full check#43
Draft
hussein-awala wants to merge 1 commit intomainfrom
Draft
fix: use put_nowait to avoid race condition on queue full check#43hussein-awala wants to merge 1 commit intomainfrom
hussein-awala wants to merge 1 commit intomainfrom
Conversation
The previous code checked queue.full() then called queue.put() as separate operations. Between the check and the put, another coroutine could add an item, causing the put to block unexpectedly. Using put_nowait() and catching QueueFull makes the operation atomic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queue.full()then calledawait queue.put()as separate operationsawait), causing the put to block unexpectedly or the check to be staleput_nowait()and catchasyncio.QueueFullto make the check-and-put atomicTest plan
test_max_queue_sizestill passes🤖 Generated with Claude Code