Skip to content

fix: use put_nowait to avoid race condition on queue full check #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hussein-awala wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: use put_nowait to avoid race condition on queue full check #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions async_batcher/batcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,10 @@ async def process(self, item: T) -> S:
self._current_task = asyncio.get_running_loop().create_task(self.run())
logging.debug(item)
future = asyncio.get_running_loop().create_future()
if self._queue.full():
try:
self._queue.put_nowait(self.QueueItem(item, future))
except asyncio.QueueFull:
raise QueueFullException("The queue is full, cannot process more items at the moment.")
await self._queue.put(self.QueueItem(item, future))
await future
return future.result()

Expand Down
Loading