glow: enable GL_ARB_explicit_attrib_location to fix crashes#1703
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Feb 17, 2023
Merged
glow: enable GL_ARB_explicit_attrib_location to fix crashes#1703hecrj merged 1 commit intoiced-rs:masterfrom
hecrj merged 1 commit intoiced-rs:masterfrom
Conversation
2 tasks
Contributor
|
Presumably it would be safer (though annoying) to always query the attribute location and not rely on explicit locations, since it would work on GL implementations that only support lower versions and don't have this extension. Though hopefully this shouldn't break things anywhere it's currently working, so it should strictly improve support relative to the existing version, at least. |
Contributor
Author
hecrj
approved these changes
Feb 17, 2023
Member
hecrj
left a comment
There was a problem hiding this comment.
Thanks! Let's apply this fix for now.
Waiting for a couple of things to line up before the gradient rewrite can land.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current shaders use ARB_explicit_attrib_location without enabling the extension:
iced/glow/src/shader/common/gradient.frag
Line 10 in 92ba26b
This causes crashes: #1625