Conversation
Fix compiler errors and clippy lints produced when attempting to build using rust 1.78.
| [package] | ||
| name = "flux-core" | ||
| version = "0.154.0" | ||
| rust-version = "1.68" |
There was a problem hiding this comment.
Errrrrrrrr this says 1.68 but the PR title says 1.78?
There was a problem hiding this comment.
OH WAIT this is msrv isn't it, i thought i was looking at rust-toolchain.toml
There was a problem hiding this comment.
The version that we build with (from rust-toolchain.toml) is 1.68. I didn't really want to change that. As I understand it this sets the minimum supported version for the crate. Though we build with 1.68 it seems others are building influxdb with newer versions (#5479) so we want to support those too.
carols10cents
left a comment
carols10cents
left a comment
There was a problem hiding this comment.
Seems fine, one question/suggestion, but it's probably my lack of context so I'm approving it regardless
| fn into_type(self) -> MonoType; | ||
| fn error(&self, error: Error) -> Self::Error; | ||
| #[allow(dead_code)] | ||
| fn location(&self) -> crate::ast::SourceLocation; |
There was a problem hiding this comment.
Is there a reason to keep these methods around in the trait definition if they're not used anywhere? I have zero context for this trait, so feel free to ignore me.
There was a problem hiding this comment.
Mainly because I didn't want to mess with the code any more than I have to. I don't really know much about how this library works, other than it having a scarily brittle build process for interfacing with the go part of the system.
2 participants
Fix compiler errors and clippy lints produced when attempting to build using rust 1.78.
Closes #5479
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.