feat: Adds logging when there are no shards during backup and restore#27035
Open
feat: Adds logging when there are no shards during backup and restore#27035
Conversation
davidby-influx
requested changes
Jan 6, 2026
Contributor
davidby-influx
left a comment
davidby-influx
left a comment
There was a problem hiding this comment.
Suggestions for even more logging information.
| for _, rpManifest := range rpManifests { | ||
| for _, sg := range rpManifest.ShardGroups { | ||
| if len(sg.Shards) <= 0 && sg.DeletedAt == nil { | ||
| b.logger.Warn("Backup: ShardGroup has not been deleted and has no shards", |
Contributor
There was a problem hiding this comment.
Can we print the database and retention policy (or bucket, or whatever) here?
| for _, rps := range b.RetentionPolicies { | ||
| for _, sg := range rps.ShardGroups { | ||
| if len(sg.Shards) <= 0 && sg.DeletedAt == nil { | ||
| h.Logger.Warn("Restore: ShardGroup has not been deleted and has no shards", |
Contributor
There was a problem hiding this comment.
As comment above, can we print the database and retention policy, or bucket, or whatever?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are experiencing a bug where we have
nullshards for a givenShardGroupin the boltdb metadata. This seems to show up during backup -> restore. Currently we have not been able to reproduce organically. This PR adds logging to backup and restore handlers for when a givenShardGroupmetadata is like the following example:Notice there is no
DeletedAtand theShardsarenull. This is what we want to avoid.Example for backup:
Example for restoration: