Skip to content

feat: Check if shards len is less than or equal to 1#27041

Open
devanbenz wants to merge 1 commit intomain-2.xfrom
db/shard-len
Open

feat: Check if shards len is less than or equal to 1#27041
devanbenz wants to merge 1 commit intomain-2.xfrom
db/shard-len

Conversation

@devanbenz
Copy link

@devanbenz devanbenz commented Dec 22, 2025 •
edited
Loading

Might be related to bug we are seeing where we end up with ShardGroups that have null shards without a DeleteAt time like the following, but very unlikely. 0 as an invariant is not possible afaik:

            {
              "ID": 789,
              "StartTime": "2025-12-01T00:00:00Z",
              "EndTime": "2025-12-08T00:00:00Z",
              "DeletedAt": "0001-01-01T00:00:00Z",
              "Shards": null,
              "TruncatedAt": "0001-01-01T00:00:00Z"
            },

Related logging PR: #27035

@philjb philjb added the area/2.x OSS 2.0 related issues and PRs label Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@devanbenz devanbenz

Labels

area/2.x OSS 2.0 related issues and PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devanbenz @philjb