Migrate ResumePlugin to BookReaderPlugin#1375
Merged
cdrini merged 2 commits intointernetarchive:masterfrom Feb 19, 2025
Merged
Conversation
8bc0107 to
d7bd63d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1375 +/- ##
=======================================
Coverage 69.21% 69.21%
=======================================
Files 60 60
Lines 5146 5146
Branches 1101 1102 +1
=======================================
Hits 3562 3562
Misses 1555 1555
Partials 29 29 ☔ View full report in Codecov by Sentry. |
d7bd63d to
44d12df
Compare
44d12df to
be94691
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #1374 , so ignore the autoplay files in this diff.
Testing:
#...fragment from the url and reload the pageBreaking changes:
BookReader#getResumeValue()moved toBookReader._plugins.resume.getResumeValue(). Similarly forgetCookiePath, andupdateResumeValue.enablePageResume: boolhas been renamed toplugins.resume.enabled: boolresumeCookiePath: stringhas been renamed toplugins.resume.cookiePath: string