Skip to content

Migrate AutoplayPlugin to BookReaderPlugin#1374

Merged
cdrini merged 4 commits intointernetarchive:masterfrom
cdrini:refactor/autoplay-br-plugin
Feb 19, 2025
Merged

Migrate AutoplayPlugin to BookReaderPlugin#1374
cdrini merged 4 commits intointernetarchive:masterfrom
cdrini:refactor/autoplay-br-plugin

Conversation

@cdrini
Copy link
Copy Markdown
Contributor

@cdrini cdrini commented Jan 30, 2025

Testing:

Breaking changes:

  • Moves the root autoplay bookreader methods/fields autoToggle, autoTimer, autoStop to br._plugins.autoplay as toggle, timer, stop
  • Moves the root autoplay options flipDelay, enableAutoPlayPlugin out of the root options to options.plugins.autoplay as flipDelay and enabled.

New features:

  • Adds new option for autoplay plugin, urlParams, defaulting to true. When true, autoflip=1, flipSpeed=<number> and flipDelay=<number> will be read from the url to configure the autoplay plugin.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 69.44444% with 22 lines in your changes missing coverage. Please review.

Project coverage is 69.21%. Comparing base (c067962) to head (0b79820).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/plugin.autoplay.js 70.83% 14 Missing ⚠️
src/BookReader.js 68.75% 5 Missing ⚠️
src/BookReader/Mode2UpLit.js 0.00% 2 Missing ⚠️
src/plugins/url/plugin.url.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
- Coverage   69.25%   69.21%   -0.04%     
==========================================
  Files          60       60              
  Lines        5135     5146      +11     
  Branches     1087     1101      +14     
==========================================
+ Hits         3556     3562       +6     
- Misses       1550     1555       +5     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini force-pushed the refactor/autoplay-br-plugin branch from 91d2986 to 113f59e Compare January 30, 2025 20:25
@cdrini cdrini force-pushed the refactor/autoplay-br-plugin branch from 113f59e to f6bbd87 Compare January 30, 2025 20:28
@cdrini cdrini marked this pull request as ready for review January 30, 2025 23:05
@cdrini cdrini force-pushed the refactor/autoplay-br-plugin branch from 552ea54 to 0b79820 Compare February 1, 2025 01:54
@cdrini
Copy link
Copy Markdown
Contributor Author

cdrini commented Feb 19, 2025

Auto-merging this one to help unblock some upcoming BR work, and since it's a refactor.

@cdrini cdrini merged commit 32b10df into internetarchive:master Feb 19, 2025
@cdrini cdrini deleted the refactor/autoplay-br-plugin branch February 19, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant