Migrate AutoplayPlugin to BookReaderPlugin#1374
Merged
cdrini merged 4 commits intointernetarchive:masterfrom Feb 19, 2025
Merged
Migrate AutoplayPlugin to BookReaderPlugin#1374cdrini merged 4 commits intointernetarchive:masterfrom
cdrini merged 4 commits intointernetarchive:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1374 +/- ##
==========================================
- Coverage 69.25% 69.21% -0.04%
==========================================
Files 60 60
Lines 5135 5146 +11
Branches 1087 1101 +14
==========================================
+ Hits 3556 3562 +6
- Misses 1550 1555 +5
Partials 29 29 ☔ View full report in Codecov by Sentry. |
91d2986 to
113f59e
Compare
113f59e to
f6bbd87
Compare
cdrini
commented
Jan 31, 2025
Better kiosk experience
This was referenced Feb 1, 2025
552ea54 to
0b79820
Compare
Contributor
Author
|
Auto-merging this one to help unblock some upcoming BR work, and since it's a refactor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing:
Breaking changes:
autoToggle,autoTimer,autoStoptobr._plugins.autoplayastoggle,timer,stopflipDelay,enableAutoPlayPluginout of the root options tooptions.plugins.autoplayasflipDelayandenabled.New features:
urlParams, defaulting to true. When true,autoflip=1,flipSpeed=<number>andflipDelay=<number>will be read from the url to configure the autoplay plugin.