Migrate TtsPlugin to BookReaderPlugin#1376
Merged
cdrini merged 5 commits intointernetarchive:masterfrom Feb 19, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1376 +/- ##
==========================================
+ Coverage 69.21% 69.28% +0.06%
==========================================
Files 60 60
Lines 5146 5150 +4
Branches 1102 1103 +1
==========================================
+ Hits 3562 3568 +6
+ Misses 1555 1552 -3
- Partials 29 30 +1 ☔ View full report in Codecov by Sentry. |
cdrini
force-pushed
the
refactor/tts-br-plugin
branch
from
c292184 to
9a2e689
Compare
cdrini
force-pushed
the
refactor/tts-br-plugin
branch
from
cbe933a to
4f9c9a6
Compare
- Breaking change: TTS `server` and `bookPath` options replaced with `pageChunkUrl` StringWithVars
The threshold field is already in percentage, it doesn't need to be /100
cdrini
force-pushed
the
refactor/tts-br-plugin
branch
from
4f9c9a6 to
15c2eb2
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #1374 , so ignore the autoplay files in this diff
Breaking Changes:
BookReader#ttsToggle,BookReader#ttsScrollToChunk,BookReader#ttsStart, etc, have all been moved to e.g.br._plugins.tts.toggle. That is they are now on theTtsPluginclass, and no longer have thettsas inttsStart.enableTtsPluginhas been renamed toplugins.tts.enabledserverandbookPathhave been replaced withpageChunkUrlStringWithVars. This makes the page chunk URL configurable for other clients.