Update nginx configurations

[jimchamp]

Updates the nginx configurations for the web_nginx and covers_nginx containers. Using the http2 parameter in listen directives has been deprecated.

listen directive documentation
http2 directive documentation

Technical

Testing

Screenshot

Stakeholders

[Copilot]

Pull request overview

Updates the nginx site configs used by the web_nginx and covers_nginx containers to avoid using the deprecated http2 parameter on listen directives.

Changes:

• Removes http2 from listen ... directives for IPv4/IPv6 TLS listeners.
• Enables HTTP/2 via the http2 on; directive in the relevant server blocks.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
docker/web_nginx.conf	Switches HTTP/2 enablement from listen ... http2 to http2 on; in the default TLS server.
docker/covers_nginx.conf	Switches HTTP/2 enablement from listen ... http2 to http2 on; in the default TLS server.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

http2 on; is only enabled in the server_name localhost server block. The actual vhost(s) in this file (e.g. openlibrary.org, www.openlibrary.org) may therefore not negotiate HTTP/2 anymore after this change. To preserve prior behavior, enable HTTP/2 on the server blocks that serve real hostnames (or otherwise ensure the setting applies to all HTTPS vhosts on :443).

Suggested change

	server_name localhost;
	server_name localhost openlibrary.org www.openlibrary.org;

[Copilot]

http2 on; is only set in the server_name localhost block. The covers.openlibrary.org server block below appears to be the primary vhost, and it does not enable HTTP/2; this may inadvertently disable HTTP/2 for that domain. Consider enabling HTTP/2 for the covers.openlibrary.org vhost as well (or otherwise applying the setting across all HTTPS vhosts on :443).

[mekarpeles]

Let's patch deploy before next deploy, and can use APPLY_OPTIONS=-R to go back if needed.