Skip to content

Update nginx configurations #12076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mekarpeles merged 1 commit into from
Mar 24, 2026
+6 −4
Merged

Update nginx configurations #12076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docker/covers_nginx.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# Keep in sync with web_nginx.conf
server {
listen 80 default;
listen [::]:443 ssl http2 ipv6only=on;
listen 443 ssl http2;
listen [::]:443 ssl ipv6only=on;
listen 443 ssl;
http2 on;
server_name localhost;
Comment on lines +4 to 7
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http2 on; is only set in the server_name localhost block. The covers.openlibrary.org server block below appears to be the primary vhost, and it does not enable HTTP/2; this may inadvertently disable HTTP/2 for that domain. Consider enabling HTTP/2 for the covers.openlibrary.org vhost as well (or otherwise applying the setting across all HTTPS vhosts on :443).

Copilot uses AI. Check for mistakes.

ssl_certificate /etc/letsencrypt/live/covers.openlibrary.org/fullchain.pem;
Expand Down
5 changes: 3 additions & 2 deletions docker/web_nginx.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@ map $request_uri $probably_requires_referer {
# Keep in sync with covers_nginx.conf
server {
listen 80 default;
listen [::]:443 ssl http2 ipv6only=on;
listen 443 ssl http2;
listen [::]:443 ssl ipv6only=on;
listen 443 ssl;
http2 on;
server_name localhost;
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http2 on; is only enabled in the server_name localhost server block. The actual vhost(s) in this file (e.g. openlibrary.org, www.openlibrary.org) may therefore not negotiate HTTP/2 anymore after this change. To preserve prior behavior, enable HTTP/2 on the server blocks that serve real hostnames (or otherwise ensure the setting applies to all HTTPS vhosts on :443).

Suggested change
server_name localhost;
server_name localhost openlibrary.org www.openlibrary.org;

Copilot uses AI. Check for mistakes.

ssl_certificate /etc/letsencrypt/live/openlibrary.org/fullchain.pem;
Expand Down
Loading