Nacho/robust kernel colorized icp#2497
Conversation
This somehow extends PR isl-org#2425
Ideally one could also add a robust kernel in this step. This extends PR isl-org#2425
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
After changing how we compute the Jacbonians API
|
Clones added
============
- cpp/open3d/pipelines/registration/ColoredICP.h 1
See the complete overview on Codacy |
|
@theNded this PR is ready to review. It doesn't add any new functionality, just some changes to the API. |
That is awesome! G-ICP is one key feature we are missing, thanks for your great contribution! |
theNded
left a comment
There was a problem hiding this comment.
Reviewed 13 of 14 files at r1, 2 of 3 files at r2, 2 of 2 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
This PR extends PR#2425.
ColoredICPpipeline.TransformationEstimationForColoredICP. I'm not sure if this was not part of the API for some reason.lambda_geomtricparameters is now expose through theTransformationEstimationForColoredICPclass.registration_colored_icpfunction has now the exact same API thatregistration_icp. With the difference that otherTransformationEstimationobjects are not accepted. These 2 functions could be merge in the future.There are still some
weight = 1.0;That I did not want to inject an explicit robust kernel there. For now, this completes the other PR in terms of the registration pipelines. More to come!This change is