-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Open
Labels
good first issueGood for beginnersGood for beginnershelp wantedFeatures that maintainers are willing to accept but do not have cycles to implementFeatures that maintainers are willing to accept but do not have cycles to implement
Description
In #5505 we introduced a revive linter, but had to disable many of its rules because they were breaking on some places in the code.
Line 154 in b38d2f9
| rules: |
We can re-enable those rules incrementally by fixing the corresponding breaks one rule at a time (make lint should succeed) and removing the disabling entry from the config.
Strong advice: DO NOT OPEN A PR without discussing the impact of the specific linter on this issue first. We don't want very possible linter - some of them are stupid, others require a lot of code changes with minimal benefits.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for beginnersGood for beginnershelp wantedFeatures that maintainers are willing to accept but do not have cycles to implementFeatures that maintainers are willing to accept but do not have cycles to implement