-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Enable unhandled-error linter #7895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable unhandled-error linter #7895
Conversation
Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7895 +/- ##
==========================================
+ Coverage 95.50% 95.51% +0.01%
==========================================
Files 312 312
Lines 16511 16512 +1
==========================================
+ Hits 15769 15772 +3
+ Misses 579 577 -2
Partials 163 163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Metrics Comparison SummaryTotal changes across all snapshots: 0 Detailed changes per snapshotsummary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
|
Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
yurishkuro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're fixing bad pattern let's actually fix it, not simply ignore the error
Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
c6bd06d
Which problem is this PR solving?
Description of the changes
unhandled-errorrule with required changes to the files.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test