Skip to content

Conversation

@iypetrov
Copy link
Contributor

@iypetrov iypetrov commented Jan 17, 2026

Which problem is this PR solving?

Description of the changes

  • Enabled the unhandled-error rule with required changes to the files.

How was this change tested?

  • make test
  • make lint

Checklist

Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
@iypetrov iypetrov requested a review from a team as a code owner January 17, 2026 22:28
@iypetrov iypetrov requested a review from pavolloffay January 17, 2026 22:28
@dosubot dosubot bot added the go Pull requests that update go code label Jan 17, 2026
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.51%. Comparing base (682db2e) to head (c120efb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7895      +/-   ##
==========================================
+ Coverage   95.50%   95.51%   +0.01%     
==========================================
  Files         312      312              
  Lines       16511    16512       +1     
==========================================
+ Hits        15769    15772       +3     
+ Misses        579      577       -2     
  Partials      163      163              
Flag Coverage Δ
badger_v1 9.19% <0.00%> (ø)
badger_v2 1.93% <0.00%> (ø)
cassandra-4.x-v1-manual 13.64% <0.00%> (ø)
cassandra-4.x-v2-auto 1.92% <0.00%> (ø)
cassandra-4.x-v2-manual 1.92% <0.00%> (ø)
cassandra-5.x-v1-manual 13.64% <0.00%> (ø)
cassandra-5.x-v2-auto 1.92% <0.00%> (ø)
cassandra-5.x-v2-manual 1.92% <0.00%> (ø)
clickhouse 1.97% <0.00%> (ø)
elasticsearch-6.x-v1 17.57% <0.00%> (ø)
elasticsearch-7.x-v1 17.60% <0.00%> (ø)
elasticsearch-8.x-v1 17.75% <0.00%> (ø)
elasticsearch-8.x-v2 1.93% <0.00%> (ø)
elasticsearch-9.x-v2 1.93% <0.00%> (ø)
grpc_v1 8.59% <0.00%> (ø)
grpc_v2 1.93% <0.00%> (ø)
kafka-3.x-v2 1.93% <0.00%> (ø)
memory_v2 1.93% <0.00%> (ø)
opensearch-1.x-v1 17.64% <0.00%> (ø)
opensearch-2.x-v1 17.64% <0.00%> (ø)
opensearch-2.x-v2 1.93% <0.00%> (ø)
opensearch-3.x-v2 1.93% <0.00%> (ø)
query 1.93% <0.00%> (ø)
tailsampling-processor 0.55% <0.00%> (ø)
unittests 94.18% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iypetrov iypetrov changed the title Enable add-constant and unhandled-error linters Draft: Enable unhandled-error linters Jan 17, 2026
@github-actions
Copy link

github-actions bot commented Jan 17, 2026

Metrics Comparison Summary

Total changes across all snapshots: 0

Detailed changes per snapshot

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 0

  • 🆕 Added: 0 metrics
  • ❌ Removed: 0 metrics
  • 🔄 Modified: 0 metrics
  • 🚫 Excluded: 106 metrics

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 0

  • 🆕 Added: 0 metrics
  • ❌ Removed: 0 metrics
  • 🔄 Modified: 0 metrics
  • 🚫 Excluded: 106 metrics

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 0

  • 🆕 Added: 0 metrics
  • ❌ Removed: 0 metrics
  • 🔄 Modified: 0 metrics
  • 🚫 Excluded: 106 metrics

➡️ View full metrics file

Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
@iypetrov iypetrov changed the title Draft: Enable unhandled-error linters Enable unhandled-error linter Jan 17, 2026
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're fixing bad pattern let's actually fix it, not simply ignore the error

Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jan 22, 2026
@yurishkuro yurishkuro enabled auto-merge January 22, 2026 15:21
@yurishkuro yurishkuro added this pull request to the merge queue Jan 22, 2026
Merged via the queue into jaegertracing:main with commit c6bd06d Jan 22, 2026
84 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable more revive linter rules

2 participants