Introduce tests for @Priority declared on stereotypes.#311
Introduce tests for @Priority declared on stereotypes.#311Ladicek merged 2 commits intojakartaee:masterfrom
Conversation
...va/org/jboss/cdi/tck/tests/definition/stereotype/priority/AlternativePriorityStereotype.java
Outdated
Show resolved
Hide resolved
...n/java/org/jboss/cdi/tck/tests/definition/stereotype/priority/AnotherPriorityStereotype.java
Outdated
Show resolved
Hide resolved
impl/src/main/java/org/jboss/cdi/tck/tests/definition/stereotype/priority/DeltaAlt2.java
Outdated
Show resolved
Hide resolved
|
Incorporated javadoc suggestions, the only remaining questionmark is #311 (comment) |
|
Just to repeat it here: maybe add a test or two with an |
True, we could add at least a simple test to see if the working case (single `@Priority) is inherited properly. |
|
@Ladicek I have added requested tests, do you think we need any further changes? |
|
@Ladicek this PR now reflects the changes made to specification and tests for definition exception if a single stereotype indirectly declares more than one priority value. I think we are good to go now. |
...tion/stereotype/broken/multiplePriorities/ConflictingPrioritiesFromSingleStereotypeTest.java
Outdated
Show resolved
Hide resolved
|
Otherwise LGTM. |
Fixes #282
Tests are taken from Weld PR here - weld/core#2559
I also added one extra test (
testSeveralPrioritiesInSingleStereotypeHierarchy) that works with several declarations of@Priorityin a hierarchy of single stereotype. We don't explicitly define this in spec text, but it is implied by annotation inheritance and overriding.