WELD-2688 Allow usage of @Priority on stereotypes, add tests.#2559
Merged
manovotn merged 1 commit intoweld:masterfrom Nov 12, 2021
Merged
WELD-2688 Allow usage of @Priority on stereotypes, add tests.#2559manovotn merged 1 commit intoweld:masterfrom
manovotn merged 1 commit intoweld:masterfrom
Conversation
Ladicek
reviewed
Nov 4, 2021
mkouba
reviewed
Nov 5, 2021
Member
Author
|
I have added a commit that introduced two tests for inherited stereotypes - one that should succeed and one that introduces two inherited and conflicting stereotypes. I'll add the same to the TCK PR. |
manovotn
force-pushed
the
weld2688
branch
2 times, most recently
from
0165423 to
212f10c
Compare
Member
Author
|
@mkouba @Ladicek this PR is now modified so that the scenario we discussed results in a |
Ladicek
approved these changes
Nov 12, 2021
Contributor
Ladicek
left a comment
Ladicek
left a comment
There was a problem hiding this comment.
Took me a little while to realize that CDI disallows transforming annotations on annotations and hence it's fine to look directly at the Class objects :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows usage of
@Priorityon stereotypes - implements a recursive search of stereotypes for priority annotation in order to register globally enabled alternatives.