Skip to content

Fix jakartaee/persistence#713, TCK should not try to lookup by time value with fractional seconds#2184

Merged
scottmarlow merged 1 commit intojakartaee:mainfrom
beikov:jpa-713
Sep 17, 2025
Merged

Fix jakartaee/persistence#713, TCK should not try to lookup by time value with fractional seconds#2184
scottmarlow merged 1 commit intojakartaee:mainfrom
beikov:jpa-713

Conversation

@beikov
Copy link
Copy Markdown
Contributor

@beikov beikov commented Apr 11, 2025

@arjantijms
Copy link
Copy Markdown
Contributor

Something to remember when fixing Persistence tests like these; this is the fork. We also have the original that we intend to transfer to Gavin and team. See jakartaee/persistence#702

Is this fix also needed in the original?

@scottmarlow
Copy link
Copy Markdown
Member

Something to remember when fixing Persistence tests like these; this is the fork. We also have the original that we intend to transfer to Gavin and team. See jakartaee/persistence#702

Is this fix also needed in the original?

I think this pull request and other ones for the persistence-outside-container tests should be made to the Persistence Spec repo after jakartaee/persistence#715 is merged (either as a service 3.2 release change or for 4.0).

@scottmarlow
Copy link
Copy Markdown
Member

Something to remember when fixing Persistence tests like these; this is the fork. We also have the original that we intend to transfer to Gavin and team. See jakartaee/persistence#702
Is this fix also needed in the original?

I think this pull request and other ones for the persistence-outside-container tests should be made to the Persistence Spec repo after jakartaee/persistence#715 is merged (either as a service 3.2 release change or for 4.0).

Although we can continue to make Persistence changes to the tcks/apis/persistence/persistence-inside-container

@scottmarlow
Copy link
Copy Markdown
Member

Something to remember when fixing Persistence tests like these; this is the fork. We also have the original that we intend to transfer to Gavin and team. See jakartaee/persistence#702

We will keep the tcks/apis/persistence/persistence-outside-container in the Platform TCK until Persistence 4.0 is ratified. The persistence-outside-container tests are used to test persistence providers but not (Jakarta EE) Persistence containers.

The persistence-inside-container tests are still used to test (Jakarta EE) Persistence containers.

Is this fix also needed in the original?

Yes as we will keep the persistence-outside-container in the Platform TCK source repo (main branch) until Persistence 4.0 is ratified. We also need the fix in persistence-inside-container as well for EE testing.

@scottmarlow scottmarlow merged commit bf11073 into jakartaee:main Sep 17, 2025
2 of 3 checks passed
beikov added a commit to beikov/persistence that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants