Address ee.jakarta.tck.persistence.core.annotations.version.Client* failures by allowing null to be used for initial version field/property value #2187
Merged
scottmarlow merged 1 commit intojakartaee:mainfrom Apr 11, 2025
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Scott Marlow <smarlow@redhat.com>
scottmarlow
force-pushed
the
persistence_versionfailure
branch
from
1a480b6 to
7fbfe7b
Compare
Contributor
|
Same comment as: #2184 (comment) If we make changes here, do we need to sync those to the original that we're going to transfer? |
Member
Author
Not yet as the #1325 change was not made to the persistence-outside-container tests so EclilpseLink (version field/property handling) is still compatible with the persistence-outside-container tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
#2112
Related Issue(s)
Specify any related issue(s) links.
Describe the change
EclipseLink version support can use Null for the initial version for certain cases. This change is to allow null to be used for those cases.
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow