Added Storybook template#318
Added Storybook template#318swyxio merged 3 commits intojaredpalmer:masterfrom Carl-Foster:feature/react-with-storybook
Conversation
|
@jaredpalmer is this PR fair enough? I'm happy to adjust it as I really appreciate this project. |
|
@swyx? What u think? I’m fine with it? |
|
yup! fine with it too. am a fan of storybook |
|
@Carl-Foster mind adding the docs addon by default? its something i really want to encourage everyone uses |
Sorry don't really understand what you mean by this. |
|
storybook addon docs is one of their biggest new things |
|
I unfortunately couldn't get the docs addon to work with Typescript seamlessly. I think if someone starts using the template can get it to work, then they can add it later. |
|
cool! thanks v much! |
* master: (26 commits) (deps/lint): upgrade @typescript-eslint to support ?. and ?? (jaredpalmer#377) (ci): add a lint job so PRs will require passing lint (jaredpalmer#378) (clean): remove .rts_cache_* from storybook gitignore (jaredpalmer#375) Add optional chaining and nullish coalescing operators support (jaredpalmer#370) Added Storybook template (jaredpalmer#318) (fix/ci): GitHub Actions should run on PRs as well (fix/format): formatting of jaredpalmer#366 didn't pass lint Add prepare script to generated project (jaredpalmer#334) default jest to watch mode when not in CI (jaredpalmer#366) (fix): respect tsconfig esModuleInterop flag (jaredpalmer#327) fix: minor typo update rollup deps and plugins update to ts 3.7 Remove unnecessary yarn install command in GH action update README.md update README.md Use node_modules/.cache/... as cacheRoot (jaredpalmer#329) fix(lint): Only default to src test if they exist (jaredpalmer#344) Fix error when providing babel/preset-env without options (jaredpalmer#350) Replaced some sync methods for their async version ...
|
thanks for the great PR! @all-contributors please add @Carl-Foster for ideas, docs, code, tests |
|
I've put up a pull request to add @Carl-Foster! 🎉 |
agilgur5
added
the
scope: templates
4 participants
I gave this library a try to setup a design-library to be built with Storybook. Found it was more cumbersome than I thought but got it setup and felt it worthwhile to add a template here.
To enable further templates, I refactored how the template configs are defined but I'm not super happy with my implementation. Open to how that could be improved.
All feedback welcome