Skip to content

Add optional chaining and nullish coalescing operators support#370

Merged
swyxio merged 2 commits intojaredpalmer:masterfrom
LoicMahieu:fix/369
Dec 16, 2019
Merged

Add optional chaining and nullish coalescing operators support#370
swyxio merged 2 commits intojaredpalmer:masterfrom
LoicMahieu:fix/369

Conversation

@LoicMahieu
Copy link
Copy Markdown
Contributor

Closes #369

Comment thread test/fixtures/build-default/src/foo.ts Outdated
@LoicMahieu LoicMahieu changed the title Add support of optional chaining Add optional chaining and nullish coalescing operators support Dec 16, 2019
Copy link
Copy Markdown
Contributor

@ambroseus ambroseus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me.
also use this plugins and it will be nice to have them by default

@swyxio
Copy link
Copy Markdown
Collaborator

swyxio commented Dec 16, 2019

thanks guys!

@swyxio swyxio merged commit a736c77 into jaredpalmer:master Dec 16, 2019
@LoicMahieu LoicMahieu deleted the fix/369 branch December 17, 2019 15:05
sebald added a commit to sebald/tsdx that referenced this pull request Dec 19, 2019
* master: (26 commits)
  (deps/lint): upgrade @typescript-eslint to support ?. and ?? (jaredpalmer#377)
  (ci): add a lint job so PRs will require passing lint (jaredpalmer#378)
  (clean): remove .rts_cache_* from storybook gitignore (jaredpalmer#375)
  Add optional chaining and nullish coalescing operators support (jaredpalmer#370)
  Added Storybook template (jaredpalmer#318)
  (fix/ci): GitHub Actions should run on PRs as well
  (fix/format): formatting of jaredpalmer#366 didn't pass lint
  Add prepare script to generated project (jaredpalmer#334)
  default jest to watch mode when not in CI (jaredpalmer#366)
  (fix): respect tsconfig esModuleInterop flag (jaredpalmer#327)
  fix: minor typo
  update rollup deps and plugins
  update to ts 3.7
  Remove unnecessary yarn install command in GH action
  update README.md
  update README.md
  Use node_modules/.cache/... as cacheRoot (jaredpalmer#329)
  fix(lint): Only default to src test if they exist (jaredpalmer#344)
  Fix error when providing babel/preset-env without options (jaredpalmer#350)
  Replaced some sync methods for their async version
  ...
@swyxio
Copy link
Copy Markdown
Collaborator

swyxio commented Jan 24, 2020

thanks for the great PR! @all-contributors please add @LoicMahieu for code, tests

@allcontributors
Copy link
Copy Markdown
Contributor

@sw-yx

I've put up a pull request to add @LoicMahieu! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for the experimental syntax 'optionalChaining'

4 participants