deps: upgrade Babel preset-env, remove now redundant plugins#838
Merged
agilgur5 merged 1 commit intojaredpalmer:masterfrom Aug 29, 2020
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
agilgur5
added
the
scope: dependencies
agilgur5
force-pushed
the
remove-redundant-babel-plugins
branch
from
06933b2 to
9230ca3
Compare
Collaborator
Author
|
Huh... |
agilgur5
force-pushed
the
remove-redundant-babel-plugins
branch
from
9230ca3 to
d366ece
Compare
Collaborator
Author
|
Ohhh it changed the output of autoprefixer a bit... I guess because the |
- optional-chaining and nullish-coalescing are now part of
@babel/preset-env, so no need to explicitly install or configure
them anymore
- left in the regression tests though!
- previously they were new syntax and TSDX adopted them as soon as
they landed in TS
- can view current compat table here:
https://github.com/babel/babel/blob/e498bee10f0123bb208baa228ce6417542a2c3c4/packages/babel-compat-data/data/plugins.json#L24
- update autoprefixer integration test because browserslist and
caniuse-lite were updated to more recent compat tables
- `-webkit-input-placeholder` is no longer needed, but some others
are, so switch to checking for `-moz-placeholder`
- this probably fixes that "caniuse-lite is out-of-date" warning I
was getting occassionally in CI
- didn't get locally probably because I didn't install with
`--frozen-lockfile` locally, unlike in CI
agilgur5
force-pushed
the
remove-redundant-babel-plugins
branch
from
d366ece to
d628b16
Compare
agilgur5
commented
Aug 29, 2020
Collaborator
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
Fixed autoprefixer test, all tests pass now!
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
…lmer#838) - optional-chaining and nullish-coalescing are now part of @babel/preset-env, so no need to explicitly install or configure them anymore - left in the regression tests though! - previously they were new syntax and TSDX adopted them as soon as they landed in TS - can view current compat table here: https://github.com/babel/babel/blob/e498bee10f0123bb208baa228ce6417542a2c3c4/packages/babel-compat-data/data/plugins.json#L24 - update autoprefixer integration test because browserslist and caniuse-lite were updated to more recent compat tables - `-webkit-input-placeholder` is no longer needed, but some others are, so switch to checking for `-moz-placeholder` - this probably fixes that "caniuse-lite is out-of-date" warning I was getting occassionally in CI - didn't get locally probably because I didn't install with `--frozen-lockfile` locally, unlike in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
optional-chaining and nullish-coalescing are now part of
@babel/preset-env, so no need to explicitly install or configurethem anymore
they landed in TS
https://github.com/babel/babel/blob/e498bee10f0123bb208baa228ce6417542a2c3c4/packages/babel-compat-data/data/plugins.json#L24
update autoprefixer integration test because browserslist and
caniuse-lite were updated to more recent compat tables
-webkit-input-placeholderis no longer needed, but some othersare, so switch to checking for
-moz-placeholderwas getting occassionally in CI
--frozen-lockfilelocally, unlike in CITags
#370 added this shortly after the syntax landed in TS.
Misc Notes
Been meaning to do this for a while and finally got to it