Skip to content

(ci/optim): add caching for yarn install#625

Merged
agilgur5 merged 1 commit intojaredpalmer:masterfrom
agilgur5:ci-add-install-cache
Mar 19, 2020
Merged

(ci/optim): add caching for yarn install#625
agilgur5 merged 1 commit intojaredpalmer:masterfrom
agilgur5:ci-add-install-cache

Conversation

@agilgur5
Copy link
Copy Markdown
Collaborator

@agilgur5 agilgur5 commented Mar 19, 2020

- via bahmutov/npm-install
- it handles all the cache steps, yarn vs. npm, OS differences, etc
@agilgur5 agilgur5 force-pushed the ci-add-install-cache branch from ecf8e65 to f804c9e Compare March 19, 2020 00:27
@agilgur5 agilgur5 changed the title (ci): add caching for yarn install via bahmutov/npm-install (ci/optim): add caching for yarn install Mar 19, 2020
@agilgur5
Copy link
Copy Markdown
Collaborator Author

So it's at least twice as fast on the Ubuntu runs, which is great!

But it fails on Windows and macOS and is probably a bit slower as a result. Filed bahmutov/npm-install#24

@agilgur5
Copy link
Copy Markdown
Collaborator Author

Merging as some caching is still better than no caching. And any bugfixes will probably apply without needing to make any changes. If changes need to be made, can improve on this at a later date.

@agilgur5 agilgur5 merged commit 18e3c05 into jaredpalmer:master Mar 19, 2020
paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
- via bahmutov/npm-install
- it handles all the cache steps, yarn vs. npm, OS differences, etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant