Skip to content

deps: upgrade actions/cache to v2 in all templates#750

Merged
agilgur5 merged 1 commit intojaredpalmer:masterfrom
devrelm:devrelm/upgrade-cache-action
Jul 19, 2020
Merged

deps: upgrade actions/cache to v2 in all templates#750
agilgur5 merged 1 commit intojaredpalmer:masterfrom
devrelm:devrelm/upgrade-cache-action

Conversation

@devrelm
Copy link
Copy Markdown
Contributor

@devrelm devrelm commented Jun 24, 2020

actions/cache@2 has been released and comes with some useful updates.

@agilgur5
Copy link
Copy Markdown
Collaborator

Thanks, will merge this in this weekend or next week when I'm back from vacation.

The current implementation is flawed btw, as it caches node_modules instead of yarn-cache or ~/.npm.
I've been planning on changing the templates to use the npm_install action as TSDX uses as of #625, but that one is buggy on Mac and Windows and my issue report hasn't been responded to bahmutov/npm-install#24. Planning to fork and fix that, but it relies on a fork of some of the GH actions since there weren't NPM packages of them -- now there are per the changelog so that should make that easier.

This is still an improvement over the current version so still makes sense to merge until that is ready.

Copy link
Copy Markdown
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes needed.

@agilgur5 agilgur5 changed the title Upgrade actions/cache to v2 in all templates deps: upgrade actions/cache to v2 in all templates Jul 19, 2020
@agilgur5 agilgur5 merged commit 984e024 into jaredpalmer:master Jul 19, 2020
@agilgur5
Copy link
Copy Markdown
Collaborator

@allcontributors please add @devrelm for code

@allcontributors
Copy link
Copy Markdown
Contributor

@agilgur5

I've put up a pull request to add @devrelm! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants