(format): format all files, not just src/ and test/#648
Merged
agilgur5 merged 1 commit intojaredpalmer:masterfrom Mar 27, 2020
Merged
(format): format all files, not just src/ and test/#648agilgur5 merged 1 commit intojaredpalmer:masterfrom
agilgur5 merged 1 commit intojaredpalmer:masterfrom
Conversation
- fix jest.config.js formatting errors - ignore dist/ (and the default of node_modules)
agilgur5
commented
Mar 27, 2020
Collaborator
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
LGTM. Maybe should consider replacing eslintignore with symlink to gitignore?
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
- fix jest.config.js formatting errors - ignore dist/ (and the default of node_modules)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #646 where I realized when editing the
jest.config.jsthat it wasn't being linted/formatted.This also starts another conversation -- shouldn't
tsdx lintor the scripts in the templates default to'./'and not justsrc test?src testalready misses things likeexampleandstoriesas well as.eslintrc.js,jest.config.js, and any other root files or root directories.Personally I think it should default to
'./'and we'll need an.eslintignoreor symlink to.gitignorefor the templates then too since we need to ignore allnode_modules(at root and atexample) as well asdist/.See also #517 that ESLint by default does not use
.gitignorefor ignores for some reason