change: by default lint all dirs, not just src and test#914
Closed
agilgur5 wants to merge 1 commit intojaredpalmer:masterfrom
Closed
change: by default lint all dirs, not just src and test#914agilgur5 wants to merge 1 commit intojaredpalmer:masterfrom
agilgur5 wants to merge 1 commit intojaredpalmer:masterfrom
Conversation
- BREAKING: change the default lint args from 'src test' to './' - this is the same arg that's used internally and there isn't really a reason to skip some files arbitrarily; it's best practice to lint everything - this also lines up with changes to make `tsc` type-check all files, instead of just 'src' and 'types'
agilgur5
added this to the
v0.16.0 - TS 4.0, Prettier 2, ESLint Upgrades, Jest 26 milestone
This comment has been minimized.
This comment has been minimized.
agilgur5
commented
Oct 27, 2020
Collaborator
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
LGTM, pretty small change 👍
Now to wait some time before this can actually be merged...
Collaborator
Author
|
CI is failing because GitHub Actions appears to be down per the logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BREAKING: change the default lint args from 'src test' to './'
this is the same arg that's used internally and there isn't really a
reason to skip some files arbitrarily; it's best practice to lint
everything
this also lines up with changes to make
tsctype-check all files,instead of just 'src' and 'types'
Tags
tscchanges mentioned in tsconfig.json is not applied in test folder in VSCode #871 (comment) et alNotes
This is a breaking change. While it probably affects few users due to the fact that it gives a warning when nothing is specified, it is still breaking. Would make sense to add in v0.16.0 to go with the other ESLint / formatting changes.