Skip to content

Comments

feat: support devEngines.runtime in deno#8144

Merged
jdx merged 2 commits intojdx:mainfrom
risu729:devengines-deno
Feb 15, 2026
Merged

feat: support devEngines.runtime in deno#8144
jdx merged 2 commits intojdx:mainfrom
risu729:devengines-deno

Conversation

@risu729
Copy link
Contributor

@risu729 risu729 commented Feb 14, 2026

This PR adds support for parsing devEngines.runtime configuration for deno in package.json file.
This allows mise to detect Deno versions specified in the devEngines section, similar to Node.js.
https://pnpm.io/package_json#devenginesruntime

Changes

  • src/plugins/core/deno.rs: Updated parse_idiomatic_file to check for package.json and parse devEngines.runtime for deno.
  • src/package_json.rs: Added a test case for deno in devEngines.

Verification

  • Added a new test case test_deno_dev_engines in src/package_json.rs.
  • Ran cargo test package_json to verify the functionality.

Copilot AI review requested due to automatic review settings February 14, 2026 05:10
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @risu729, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances mise's Deno plugin by enabling it to read Deno version requirements from the devEngines.runtime section of package.json. This change allows for more flexible and standardized version management for Deno projects, aligning its behavior with how other runtimes might be configured, and ensures that mise can correctly identify and use the specified Deno environment.

Highlights

  • Deno Version Detection: Added support for mise to detect Deno versions specified within the devEngines.runtime field of package.json files.
  • Package.json Parsing: The Deno plugin now includes package.json in its list of idiomatic filenames and implements logic to parse it for Deno runtime versions.
  • Test Coverage: A new test case was introduced in src/package_json.rs to verify the correct parsing of Deno versions from devEngines.runtime.
Changelog
  • src/package_json.rs
    • Added test_deno_dev_engines to validate parsing of Deno versions from devEngines.runtime in package.json.
  • src/plugins/core/deno.rs
    • Modified idiomatic_filenames to include package.json as a recognized file for Deno version detection.
    • Implemented parse_idiomatic_file to extract the Deno version from package.json's devEngines.runtime field.
Activity
  • No human activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for detecting Deno versions from the devEngines.runtime field in package.json files, bringing Deno inline with Node.js and Bun which already support this feature. This allows mise to automatically detect and install the appropriate Deno version when a project specifies it in their package.json.

Changes:

  • Added package.json support to Deno's idiomatic file detection
  • Implemented parsing of devEngines.runtime.deno from package.json
  • Added unit test coverage for Deno in devEngines

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/plugins/core/deno.rs Added package.json to idiomatic filenames and implemented parse_idiomatic_file to extract Deno version from devEngines.runtime
src/package_json.rs Added test case to verify Deno version extraction from devEngines.runtime field

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for devEngines.runtime for Deno in package.json, allowing mise to detect Deno versions from it. The changes are well-implemented, including an update to the Deno plugin to parse package.json and a new test case to verify the functionality. The code is correct and follows the existing patterns in the codebase. I have no issues with the proposed changes.

@jdx jdx merged commit f231ba5 into jdx:main Feb 15, 2026
33 checks passed
@risu729 risu729 deleted the devengines-deno branch February 15, 2026 13:54
mise-en-dev added a commit that referenced this pull request Feb 16, 2026
### 🚀 Features

- **(vfox)** allow plugins to request env var redaction via
MiseEnvResult by @jdx in [#8166](#8166)
- add a default_host setting for rust by @aacebedo in
[#8154](#8154)
- add github_content package support for aqua backend by @risu729 in
[#8147](#8147)
- support devEngines.runtime in deno by @risu729 in
[#8144](#8144)

### 🐛 Bug Fixes

- **(asset_matcher)** penalize vsix files by @risu729 in
[#8151](#8151)
- **(edit)** strip formatting whitespace from TOML values in `mise edit`
by @jdx in [#8162](#8162)
- **(install)** improve --locked support for python and ubi backends by
@jdx in [#8163](#8163)
- **(npm)** suppress npm update notifier while npm install by @risu729
in [#8152](#8152)
- **(schema)** add task_templates, extends, and timeout by @risu729 in
[#8145](#8145)

### 🚜 Refactor

- **(registry)** remove [key=value] options syntax from backends by
@risu729 in [#8146](#8146)

### 📚 Documentation

- **(settings)** remove wrong tip for github_attestations by @risu729 in
[#8158](#8158)

### Chore

- **(release-plz)** delete embedded plugins directory before update by
@risu729 in [#8149](#8149)
- adds necessary env var to the mcp help message in cli by @joaommartins
in [#8133](#8133)

### New Contributors

- @joaommartins made their first contribution in
[#8133](#8133)

## 📦 Aqua Registry Updates

#### New Packages (5)

- [`containers/podlet`](https://github.com/containers/podlet)
-
[`hickford/git-credential-azure`](https://github.com/hickford/git-credential-azure)
-
[`hickford/git-credential-oauth`](https://github.com/hickford/git-credential-oauth)
- [`kovetskiy/mark`](https://github.com/kovetskiy/mark)
- [`openbao/openbao/bao`](https://github.com/openbao/openbao/bao)
lucasew pushed a commit to lucasew/CONTRIB-mise that referenced this pull request Feb 18, 2026
This PR adds support for parsing `devEngines.runtime` configuration for
`deno` in `package.json` file.
This allows `mise` to detect Deno versions specified in the `devEngines`
section, similar to Node.js.
https://pnpm.io/package_json#devenginesruntime

## Changes
- `src/plugins/core/deno.rs`: Updated `parse_idiomatic_file` to check
for `package.json` and parse `devEngines.runtime` for `deno`.
- `src/package_json.rs`: Added a test case for `deno` in `devEngines`.

## Verification
- Added a new test case `test_deno_dev_engines` in
`src/package_json.rs`.
- Ran `cargo test package_json` to verify the functionality.
lucasew pushed a commit to lucasew/CONTRIB-mise that referenced this pull request Feb 18, 2026
### 🚀 Features

- **(vfox)** allow plugins to request env var redaction via
MiseEnvResult by @jdx in [jdx#8166](jdx#8166)
- add a default_host setting for rust by @aacebedo in
[jdx#8154](jdx#8154)
- add github_content package support for aqua backend by @risu729 in
[jdx#8147](jdx#8147)
- support devEngines.runtime in deno by @risu729 in
[jdx#8144](jdx#8144)

### 🐛 Bug Fixes

- **(asset_matcher)** penalize vsix files by @risu729 in
[jdx#8151](jdx#8151)
- **(edit)** strip formatting whitespace from TOML values in `mise edit`
by @jdx in [jdx#8162](jdx#8162)
- **(install)** improve --locked support for python and ubi backends by
@jdx in [jdx#8163](jdx#8163)
- **(npm)** suppress npm update notifier while npm install by @risu729
in [jdx#8152](jdx#8152)
- **(schema)** add task_templates, extends, and timeout by @risu729 in
[jdx#8145](jdx#8145)

### 🚜 Refactor

- **(registry)** remove [key=value] options syntax from backends by
@risu729 in [jdx#8146](jdx#8146)

### 📚 Documentation

- **(settings)** remove wrong tip for github_attestations by @risu729 in
[jdx#8158](jdx#8158)

### Chore

- **(release-plz)** delete embedded plugins directory before update by
@risu729 in [jdx#8149](jdx#8149)
- adds necessary env var to the mcp help message in cli by @joaommartins
in [jdx#8133](jdx#8133)

### New Contributors

- @joaommartins made their first contribution in
[jdx#8133](jdx#8133)

## 📦 Aqua Registry Updates

#### New Packages (5)

- [`containers/podlet`](https://github.com/containers/podlet)
-
[`hickford/git-credential-azure`](https://github.com/hickford/git-credential-azure)
-
[`hickford/git-credential-oauth`](https://github.com/hickford/git-credential-oauth)
- [`kovetskiy/mark`](https://github.com/kovetskiy/mark)
- [`openbao/openbao/bao`](https://github.com/openbao/openbao/bao)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants