fix(asset_matcher): penalize vsix files

[risu729]

Fixes #7505

[gemini-code-assist]

Summary of Changes

Hello @risu729, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the asset selection mechanism by introducing a penalty for '.vsix' files. This change ensures that the AssetPicker prioritizes more commonly desired asset types over Visual Studio Code extension files, thereby improving the relevance of automatically selected assets.

Highlights

• Asset Matching Logic: Introduced a penalty for '.vsix' files within the AssetPicker's scoring mechanism, reducing their priority during asset selection.
• Test Coverage: Added a new test case, 'test_vsix_vs_gz', to specifically verify that '.gz' files are correctly prioritized over '.vsix' files.

Changelog

• src/backend/asset_matcher.rs
  • Added logic to penalize '.vsix' files by 100 points in the asset scoring system.
  • Included a new test 'test_vsix_vs_gz' to validate the preference for '.gz' files over '.vsix' files.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

This PR adds a penalty for .vsix files (Visual Studio Code extensions) in the asset matching logic to prevent them from being incorrectly selected as binary assets. The penalty value of -100 aligns with similar penalties for metadata files and non-binary formats.

Changes:

• Added -100 penalty for files ending with .vsix extension in the asset scoring logic
• Added test case test_vsix_vs_gz to verify the penalty behavior

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request correctly penalizes .vsix files in the asset matcher to prevent them from being selected as the best asset, which is appropriate since they are typically VS Code extensions. A test is added to verify this, but the test case is incomplete as it does not include a .vsix file to test against. I've suggested an improvement to the test to make it more robust and accurately reflect the intended scenario.