Skip to content

fix(asset_matcher): penalize vsix files #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 3 commits into from
Feb 15, 2026
Merged

fix(asset_matcher): penalize vsix files #8151

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca45782
fix(asset_matcher): penalize vsix files
risu729 Feb 14, 2026
d3dda28
test: update vsix test
risu729 Feb 14, 2026
fedb244
Merge branch 'main' into ignore-vsix
risu729 Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/backend/asset_matcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,11 @@ impl AssetPicker {
penalty -= 50;
}

// Penalize .vsix files
if asset.ends_with(".vsix") {
penalty -= 100;
}

// Penalize metadata/checksum/signature files
if asset.ends_with(".asc")
|| asset.ends_with(".sig")
Expand Down Expand Up @@ -1368,4 +1373,16 @@ abc123def456abc123def456abc123def456abc123def456abc123def456abcd tool-darwin.ta
"Should return the only provenance file available"
);
}

#[test]
fn test_vsix_vs_gz() {
let picker = AssetPicker::with_libc("macos".to_string(), "x86_64".to_string(), None);
let assets = vec![
"rust-analyzer-x86_64-apple-darwin.gz".to_string(),
"rust-analyzer-x86_64-apple-darwin.vsix".to_string(),
];

let picked = picker.pick_best_asset(&assets).unwrap();
assert_eq!(picked, "rust-analyzer-x86_64-apple-darwin.gz");
}
}
Loading