fix: match completion prefix against unescaped names

[ilyagr]

When using complete ... descriptions=#true, prefix matching was done against escaped strings (e.g., test\:integration) instead of unescaped names (test:integration). This caused completions to fail when user input contained an unescaped colon.

Fix by moving the filter to after the map that unescapes the names.

This bug caused a problem with mise: there was no shell completion if you entered mise test:i<tab> even if there was a test:integration task. mise run test:i<tab> was not affected, that is treated differently by mise's usage spec.

---

I feel that the test could be more readable, I might do that in a subsequent PR. I think all complete_word tests could use the fish syntax instead of the zsh syntax, so e.g.

"test:unit\tRun unit tests\ntest:integration\tRun integration tests\nbuild\tBuild the project\n"
// instead of 
"'test\\\\:unit'\\:'Run unit tests'\n'test\\\\:integration'\\:'Run integration tests'\n'build'\\:'Build the project'\n"

Let me know if you prefer I do that refactor first to make the diff here more readable (but it's not that bad)

Update: Apparently, that'd also make Copilot happer. Here's a draft: ilyagr@fish-refactor . Again, I'm happy to reorder the commits so that the cleaner syntax comes first. The biggest win from the refactor is in the test added in this PR, but others are also easier to read IMO for somebody unfamiliar with either shell's syntax.

---

This was mostly debugged by AI. If the fix is not correct, it could be considered a bug report (but it seems good to me).

---

Note

Fixes completion prefix matching when complete ... descriptions=#true by filtering after unescaping name:description outputs.

• In complete_word.rs, process command output lines first (unescape and split) then filter by ctoken, so prefixes match unescaped names containing colons
• Adds test complete_word_escaped_colons_in_completions and example colon-in-completions.usage.kdl to validate colon-containing completions

^{Written by Cursor Bugbot for commit e24490f. This will update automatically on new commits. Configure here.}

[Copilot]

Pull request overview

This PR fixes a bug where shell completion prefix matching failed when completion names contained colons. The issue occurred because filtering was performed on escaped strings (e.g., test\:integration) before unescaping, causing user input like test: to not match.

Changes:

• Moved the prefix filter operation to after the unescaping step in complete_word.rs
• Added a comprehensive test case with an example usage file to verify colon handling in completions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
cli/src/cli/complete_word.rs	Repositioned the filter to match against unescaped completion names
cli/tests/complete_word.rs	Added test function to verify prefix matching works with escaped colons
examples/colon-in-completions.usage.kdl	Added example usage configuration demonstrating colon-containing completions

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This assertion line exceeds typical line length limits (appears to be >120 characters). Consider breaking it into multiple lines for better readability, similar to how the other assertions in this test are formatted.

Suggested change

	.stdout("'test\\\\:unit'\\:'Run unit tests'\n'test\\\\:integration'\\:'Run integration tests'\n'build'\\:'Build the project'\n");
	.stdout(concat!(
	"'test\\\\:unit'\\:'Run unit tests'\n",
	"'test\\\\:integration'\\:'Run integration tests'\n",
	"'build'\\:'Build the project'\n",
	));

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (85378c5) to head (e24490f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   76.73%   76.73%           
=======================================
  Files          47       47           
  Lines        6250     6250           
  Branches     6250     6250           
=======================================
  Hits         4796     4796           
  Misses       1102     1102           
  Partials      352      352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jdx]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR